Allow forward-declaration of level_enum

spdlog::level::level_enum cannot be forward-declared at present, as
the definition does not specify an underlying type.

To allow users to make use of <spdlog/fwd.h> to refer to
level::level_enum without pulling in all of <spdlog/common.h> (which
can be quite costly), specify an underlying type (int) for
level::level_enum, then add a forward-declaration for it to
spdlog/fwd.h.

Note this required explicitly casting level_enum to size_t within ansicolor_sink due to sign-conversion errors:

    implicit conversion changes signedness: 'const level::level_enum' to 'std::__1::array::size_type' (aka 'unsigned long') [-Wsign-conversion]

It would appear that an enum with an unspecified underlying type is in
some kind of superposition - it can be treated as both signed _and_
unsigned - using an underlying type of 'unsigned int' triggers even
more warnings of this kind...
This commit is contained in:
Dave Rigby
2022-01-11 14:58:58 +00:00
parent 729d7f6d88
commit 2a4c34b878
3 changed files with 7 additions and 3 deletions

View File

@@ -11,4 +11,8 @@ namespace sinks {
class sink;
}
namespace level {
enum level_enum : int;
}
} // namespace spdlog