Moved default sync factory to seperate file to avoid cyclic includes

include/spdlog/details/registry.h

@@ -3,8 +3,8 @@
 
 #pragma once
 
-// Loggers registy of unique name->logger pointer
-// An attempt to create a logger with an already existing name will be ignored
+// Loggers registry of unique name->logger pointer
+// An attempt to create a logger with an already existing name will result with spdlog_ex exception.
 // If user requests a non existing logger, nullptr will be returned
 // This class is thread safe
 

include/spdlog/details/synchronous_factory.h

@@ -0,0 +1,22 @@
+// Copyright(c) 2015-present Gabi Melman & spdlog contributors.
+// Distributed under the MIT License (http://opensource.org/licenses/MIT)
+
+#pragma once
+
+#include "registry.h"
+
+namespace spdlog {
+
+// Default logger factory-  creates synchronous loggers
+    class logger;
+
+    struct synchronous_factory {
+        template<typename Sink, typename... SinkArgs>
+        static std::shared_ptr<spdlog::logger> create(std::string logger_name, SinkArgs &&... args) {
+            auto sink = std::make_shared<Sink>(std::forward<SinkArgs>(args)...);
+            auto new_logger = std::make_shared<spdlog::logger>(std::move(logger_name), std::move(sink));
+            details::registry::instance().initialize_logger(new_logger);
+            return new_logger;
+        }
+    };
+}