Fixed some extra warnings from clang

include/spdlog/details/async_logger_impl.h

@@ -107,4 +107,4 @@ inline std::shared_ptr<spdlog::logger> spdlog::async_logger::clone(std::string n
     cloned->flush_on(this->flush_level());
     cloned->set_error_handler(this->error_handler());
     return std::move(cloned);
-}
+}

include/spdlog/details/thread_pool.h

@@ -198,6 +198,13 @@ private:
 
         switch (incoming_async_msg.msg_type)
         {
+        case async_msg_type::log:
+        {
+            log_msg msg;
+            incoming_async_msg.to_log_msg(msg);
+            incoming_async_msg.worker_ptr->backend_log_(msg);
+            return true;
+        }
         case async_msg_type::flush:
         {
             incoming_async_msg.worker_ptr->backend_flush_();
@@ -208,16 +215,9 @@ private:
         {
             return false;
         }
-
-        default:
-        {
-            log_msg msg;
-            incoming_async_msg.to_log_msg(msg);
-            incoming_async_msg.worker_ptr->backend_log_(msg);
-            return true;
         }
-        }
-        return true; // should not be reached
+        assert(false && "Unexpected async_msg_type");
+        return true;
     }
 };
 

include/spdlog/sinks/sink.h

@@ -22,7 +22,9 @@ public:
 
     explicit sink(std::unique_ptr<spdlog::pattern_formatter> formatter)
         : level_(level::trace)
-        , formatter_(std::move(formatter)){};
+        , formatter_(std::move(formatter))
+    {
+    }
 
     virtual ~sink() = default;
     virtual void log(const details::log_msg &msg) = 0;